tests missing diff

[burlen]

a number of tests run the pipeline without checking the result. these can be fixed now that we have mesh based diff.

1. test_temporal_average.cpp
2. test_cf_reader.cpp
3. test_programmable_algorithm.py
4. test_derived_quantity.py
5. test_connected_components.py
6. test_cf_reader.py
7. test_vector_ops.py
8. test_binary_segmentation.cpp

use dataset_diff in these tests to validate the output

[elbashandy]

This is done but will not close it because the cf_reader is giving an error with the cam5 dataset.

The error:

test 6
    Start 6: test_cf_reader_cam5

6: Test command: /project/TECA_build/bin/test/test_cf_reader "-i" "/user_host/TECA_data/cam5_1_amip_run2\.cam2\.h2\.1991-10-[0-9][0-9]-10800\.nc" "-o" "/user_host/TECA_data/test_cf_reader_cam5.bin" "-s" "1,2" "-x" "lon" "-y" "lat" "-t" "time" "U850" "V850"
6: Test timeout computed to be: 1500
6: STATUS: [0:139878790192064] [/user_host/TECA/io/teca_cf_reader.cxx:389 2.2.1-225-g1ee302e]
6: STATUS: Found metadata cache "/user_host/TECA_data/4ba9d904ca81b960467deed857eca3214cabf3ad.md"
6: ERROR: [0:139878790192064] [/user_host/TECA/alg/teca_dataset_diff.cxx:366 2.2.1-225-g1ee302e]
6: ERROR: relative difference 0.177221 exceeds tolerance 1e-06 in element 0. ref value "-2.86862" is not equal to test value "-2.36024"
6: ERROR: [0:139878790192064] [/user_host/TECA/alg/teca_dataset_diff.cxx:425 2.2.1-225-g1ee302e]
6: ERROR: difference in array 0 "U850"
6: ERROR: [0:139878790192064] [/user_host/TECA/alg/teca_dataset_diff.cxx:471 2.2.1-225-g1ee302e]
6: ERROR: difference in point arrays
6: ERROR: [0:139878790192064] [/user_host/TECA/alg/teca_dataset_diff.cxx:247 2.2.1-225-g1ee302e]
6: ERROR: Failed to compare cartesian meshes.
1/1 Test #6: test_cf_reader_cam5 ..............***Failed  Error regular expression found in output. Regex=[ERROR]  0.27 sec

[burlen]

@elbashandy It is not done if there is a failing test.

is there a MR related to the above commit?

[elbashandy]

No I didn't do a merge request till we fix that issue.

[burlen]

see also #256