Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up and merge the Breathe example #594

Closed
burlen opened this issue Apr 6, 2021 · 4 comments
Closed

clean up and merge the Breathe example #594

burlen opened this issue Apr 6, 2021 · 4 comments
Assignees
Labels
1_high_priority an issue that should be fixed prior to the next release

Comments

@burlen
Copy link
Collaborator

burlen commented Apr 6, 2021

#505 illustrates Breathe working. This functionality will be used in the catalogue of algorithms and data model documentation that in in progress. Please put the just the changes that illustrate Breathe into a new PR for review.

@burlen burlen added the 1_high_priority an issue that should be fixed prior to the next release label Apr 6, 2021
@elbashandy
Copy link
Contributor

@burlen can you elaborate more on why we need Breathe to be integrated? I haven't settled on the approach on how we are going to add the cataloging feature we are going to add. So far I am not leaning towards Breathe unless it's obviously the best solution.

@burlen
Copy link
Collaborator Author

burlen commented Apr 6, 2021

I am going to use Breathe as I write documentation, which has no connection to what you've been working on or will work on. You're work on getting Breathe going is very helpful and we don't want to loose it.

@elbashandy
Copy link
Contributor

Thank you for explaining! I will get it ready 👍

@burlen
Copy link
Collaborator Author

burlen commented May 5, 2021

resolved in #596

@burlen burlen closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_high_priority an issue that should be fixed prior to the next release
Projects
None yet
Development

No branches or pull requests

2 participants