Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Breathe into TECA #596

Merged
merged 24 commits into from
May 5, 2021
Merged

Integrating Breathe into TECA #596

merged 24 commits into from
May 5, 2021

Conversation

elbashandy
Copy link
Contributor

I only added Breathe into TECA but haven't used it in the documentation. In order to know how to use it, follow the Breathe guide.

To use Breathe in rst format, it will look something like this:

.. doxygenclass:: teca_2d_component_area
   :members:
   :protected-members:
   :private-members:
   :undoc-members:

To remove the private members from the documentation for example, remove the line that has :private-members:

@burlen
Copy link
Collaborator

burlen commented Apr 12, 2021

please include the example that you had in the original pr. There's no need to worry too much about the formatting etc, what you had shown before is fine. I'll make a pass over it from there.

@elbashandy
Copy link
Contributor Author

@burlen I am not sure I follow which example you are referring to. Are you talking about the extra C++ documentation that I added to the code? for example: commit 3f151c407ac795d5f056926b456afd4522d68e74. Or are you referring to the framework pages that I added in 01e85023f9aaf268b4c930cc5173f287a33e35a4?

@elbashandy elbashandy force-pushed the integrating_breathe branch from dec1f97 to 82f596d Compare April 12, 2021 22:42
@burlen
Copy link
Collaborator

burlen commented Apr 13, 2021

I'm referring to the changes that put some classes in the rtd users guide using breathe. This showed that things were working. I would like you to post a link to rtd showing this pr working as well.

@elbashandy elbashandy force-pushed the integrating_breathe branch from 46fc1c5 to 720b4a3 Compare April 14, 2021 22:23
@elbashandy
Copy link
Contributor Author

@burlen I cherry-picked the commit that has the class pages, where each page has breathe covering some of the components:

https://teca.readthedocs.io/en/integrating_breathe/framework/framework.html

Let me know if you are referring to something else.

@burlen
Copy link
Collaborator

burlen commented Apr 19, 2021

Thanks Abdel! I'll take it from here

@burlen burlen force-pushed the integrating_breathe branch 5 times, most recently from 4524321 to 249779c Compare April 28, 2021 18:41
@burlen
Copy link
Collaborator

burlen commented Apr 28, 2021

resolves #610
resolves #609
resolves #608
resolves #607
resolves #606
resolves #605
resolves #604
resolves #603
resolves #602
resolves #594
resolves #592

includes a abunch of the work for #595

Note: githuib only allows linking of 10 issues, need to close #594 manually.

@burlen burlen force-pushed the integrating_breathe branch from f0406ff to a49029d Compare May 5, 2021 18:31
burlen added 7 commits May 5, 2021 11:52
* doxygen format on TECA_ALGORITHM_PROPERTY and other similar macros
* remove X_fwd.h files
* remove @anchor and @ref on algorithm, properties because anchor names
  need to be unique project wide.
* more doxygen formatting of classes
@burlen burlen force-pushed the integrating_breathe branch 2 times, most recently from 753091f to 2d20316 Compare May 5, 2021 19:54
revert this commit once RTD.org updates to Ubtunu 20.04
see issue 613 for more info
@burlen burlen force-pushed the integrating_breathe branch from 2d20316 to 309b592 Compare May 5, 2021 20:07
@burlen burlen merged commit 1efc41e into develop May 5, 2021
@burlen burlen deleted the integrating_breathe branch May 5, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment