Claim strong typing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are guaranteed to fail on at least one unused version of python, so they are ignored.
|
Thank you for contributing to this library. I've finally taken the time to find out more about type information distribution and I don't see anything to change in your pull request. Can I merge? |
|
Thanks for the feedback @LBeaudoux! I'm happy for you to merge this if you don't have any changes you'd like made. Thanks for all the great work you do maintaining this library, it's very appreciated. |
|
I merge. A new release should be out soon. Thanks again for your time @LachJones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #26 this PR claims explicit typing of the library, allowing for type checkers to examine types in this codebase and enable type checking of other codebases which import this library.
There are no intended changes to library behaviour in this PR. There is an additional job added to the workflows file which performs type checking alongside already existing tests.
Typing errors on imports in
datafile.pyhave been ignored, as these imports are python version dependant and will fail for the import intended for other versions of python, much in the same way the import itself will fail (due to not being able to find that import).Closes #26.