Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python 3.11 #1146

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Add support for python 3.11 #1146

merged 3 commits into from
Dec 8, 2023

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Dec 3, 2023 •
edited
Loading

  • Update requirements
  • Add support for py=3.11 and Test AB working on python versions 3.8, 3.9 and 3.11

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Request a review from another developer.

@marc-vdm marc-vdm mentioned this pull request Dec 3, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 50.055% (+0.09%) from 49.967%
when pulling 80be28e on marc-vdm:py311-312
into f8c8561 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm requested a review from haasad December 6, 2023 11:06
@marc-vdm marc-vdm marked this pull request as ready for review December 6, 2023 11:07
@marc-vdm marc-vdm changed the title test py3.11 and py3.12 Add support for python 3.11 Dec 6, 2023
@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Dec 6, 2023
haasad
haasad approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@haasad haasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marc-vdm
Copy link
Member Author

marc-vdm commented Dec 8, 2023

Thanks a lot for thinking along here!

@marc-vdm marc-vdm merged commit d5b9e75 into LCA-ActivityBrowser:master Dec 8, 2023
12 checks passed
@marc-vdm marc-vdm deleted the py311-312 branch May 14, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haasad haasad haasad approved these changes

Assignees
No one assigned
Labels
change PRs related to minor changes to AB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-vdm @coveralls @haasad