Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip integer fix #1168

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

mrvisscher
Copy link
Collaborator

Fixes a bug with the previous table overflow tooltip functionality where an error is thrown when the table cell data iss not of type String.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Dec 11, 2023
@coveralls
Copy link

Coverage Status

coverage: 50.055%. remained the same
when pulling c4bbde2 on mrvisscher:tooltip-integer-fix
into d5b9e75 on LCA-ActivityBrowser:master.

@marc-vdm
Copy link
Member

Could you check if this works in combination with #1151 and we get a useful date value and not a Unix time string or something?

@marc-vdm marc-vdm added this to the 2.9.3 milestone Dec 13, 2023
@marc-vdm marc-vdm removed the bug Issues/PRs related to bugs label Dec 13, 2023
@marc-vdm marc-vdm merged commit c3fd2c2 into LCA-ActivityBrowser:master Dec 13, 2023
12 checks passed
Copy link

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.

@mrvisscher mrvisscher deleted the tooltip-integer-fix branch January 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants