Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed threading issue in Biosphere patcher #1200

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

mrvisscher
Copy link
Collaborator

This PR fixes an issue where patches are being applied while the biosphere is still being installed, causing the patches to fail and the final biosphere DB to be unpatched.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Request a review from another developer.

@coveralls
Copy link

coveralls commented Jan 12, 2024

Coverage Status

coverage: 50.944% (+0.07%) from 50.879%
when pulling e951062 on mrvisscher:biosphere-updater-fix
into 6931bad on LCA-ActivityBrowser:master.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Jan 12, 2024
@marc-vdm marc-vdm added this to the 2.9.5 milestone Jan 19, 2024
@marc-vdm marc-vdm merged commit 17f432a into LCA-ActivityBrowser:master Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants