Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard actually destroyed, any threads safely exited #1205

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jan 18, 2024

The database import wizard was not properly deleted at first, leading to multiple wizard instances reacting to signals, causing mayhem. The wizard is now properly closed, and threads are safely finished.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.
  • Check-out on Linux because of Make DatabaseImportWizard more secure #44
    • test:
      • Linux working
      • Linux not 2 wizards open at 1 time

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Jan 18, 2024
@coveralls
Copy link

coveralls commented Jan 18, 2024

Coverage Status

coverage: 50.932% (+0.05%) from 50.879%
when pulling 1e331f1 on mrvisscher:multi-wizard-fix
into 6931bad on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm added this to the 2.9.5 milestone Jan 24, 2024
@mrvisscher mrvisscher merged commit fc7c1ff into LCA-ActivityBrowser:master Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants