Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-found CS aspects in tables for deletion #1388

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Oct 1, 2024

Activities and Methods that are deleted are not automatically deleted from calculations setups. With this PR we show these missing Activities and Methods in their respective CS tables so they can be deleted manually.

image

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Oct 1, 2024
@mrvisscher mrvisscher added this to the 2.10.3 milestone Oct 1, 2024
@coveralls
Copy link

coveralls commented Oct 1, 2024

Coverage Status

coverage: 54.217% (-0.03%) from 54.245%
when pulling 5619c35 on mrvisscher:cs-act-mthd-deletion
into 0068e31 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit e63ace0 into LCA-ActivityBrowser:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a database does not remove activity from calculation setup
3 participants