Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend simplified enzyme model to include multiple capacity constraints #772

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Extend simplified enzyme model to include multiple capacity constraints #772

merged 2 commits into from
Mar 6, 2023

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Mar 2, 2023

No description provided.

@stelmo stelmo requested a review from exaexa March 2, 2023 23:28
exaexa
exaexa requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rebase this atop the pfba PR (and merge into that one) since the wrappers moved.

other than that I guess it looks okay.

@stelmo stelmo force-pushed the mo-extend-simplified-enzyme branch from 80fa8a5 to 9c3b418 Compare March 5, 2023 10:30
@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

✔️ Auto-formatting triggered by this comment succeeded, commited as 3899607

github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
@stelmo
automatic formatting
3899607 
triggered by @stelmo on PR #772
@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

No idea why next is not failing on this test :/ the solver seems to give different values for the exact same problem... Changed the solver expected solution to report fewer decimal places

@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

Will rebase on #773

@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

✔️ Auto-formatting triggered by this comment succeeded, commited as ed0da18

github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
@stelmo
automatic formatting
ed0da18 
triggered by @stelmo on PR #772
@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 82.92% and project coverage change: +2.74 🎉

Comparison is base (10b0a29) 86.55% compared to head (be78535) 89.30%.

❗ Current head be78535 differs from pull request most recent head 628461f. Consider uploading reports for the commit 628461f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next     #772      +/-   ##
==========================================
+ Coverage   86.55%   89.30%   +2.74%     
==========================================
  Files          93       92       -1     
  Lines        2388     2422      +34     
==========================================
+ Hits         2067     2163      +96     
+ Misses        321      259      -62
Impacted Files Coverage Δ
src/wrappers/bits/enzyme_constrained.jl 100.00% <ø> (ø)
src/types/wrappers/EqualGrowthCommunityModel.jl 81.57% <33.33%> (+81.57%) ⬆️
src/types/models/CommunityModel.jl 95.23% <50.00%> (+40.10%) ⬆️
...rc/reconstruction/simplified_enzyme_constrained.jl 100.00% <100.00%> (ø)
src/wrappers/SimplifiedEnzymeConstrainedModel.jl 88.88% <100.00%> (+10.31%) ⬆️
src/wrappers/misc/enzyme_constrained.jl 100.00% <100.00%> (ø)
src/wrappers/EnzymeConstrainedModel.jl 95.34% <0.00%> (+2.32%) ⬆️
src/types/misc/CommunityModel.jl 95.65% <0.00%> (+26.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo stelmo force-pushed the mo-extend-simplified-enzyme branch from ed0da18 to 5901bec Compare March 5, 2023 11:40
@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

✔️ Auto-formatting triggered by this comment succeeded, commited as a458d78

github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
@stelmo
automatic formatting
a458d78 
triggered by @stelmo on PR #772
stelmo added a commit that referenced this pull request Mar 5, 2023
@stelmo
automatic formatting
7225b01 
triggered by @stelmo on PR #772
@stelmo stelmo force-pushed the mo-extend-simplified-enzyme branch from a458d78 to 7225b01 Compare March 5, 2023 15:06
@stelmo stelmo changed the base branch from next to mk-pfba-is-l2 March 5, 2023 15:06
Base automatically changed from mk-pfba-is-l2 to mo-pfba-pipe March 5, 2023 18:27
Base automatically changed from mo-pfba-pipe to next March 5, 2023 19:00
@stelmo stelmo force-pushed the mo-extend-simplified-enzyme branch from 7225b01 to 8830b14 Compare March 5, 2023 19:18
@stelmo stelmo force-pushed the mo-extend-simplified-enzyme branch from 8830b14 to 3bb0cb2 Compare March 5, 2023 19:20
@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

✔️ Auto-formatting triggered by this comment succeeded, commited as d39fc03

github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
@stelmo
automatic formatting
d39fc03 
triggered by @stelmo on PR #772
@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

☀️ Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly.

@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

✔️ Auto-formatting triggered by this comment succeeded, commited as be78535

github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
@stelmo
automatic formatting
be78535 
triggered by @stelmo on PR #772
@stelmo stelmo force-pushed the mo-extend-simplified-enzyme branch from be78535 to 628461f Compare March 5, 2023 21:37
@stelmo stelmo requested a review from exaexa March 5, 2023 21:37
@stelmo
Copy link
Collaborator Author

stelmo commented Mar 5, 2023

Finally fixed this! Should also fix the broken things in next

exaexa
exaexa approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kewl

@exaexa exaexa merged commit de79c61 into next Mar 6, 2023
@exaexa exaexa deleted the mo-extend-simplified-enzyme branch March 6, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exaexa exaexa exaexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stelmo @exaexa