-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use distributed processing from DiDa #203
Conversation
(it was commented out anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficult to check every line of it, but looks good as far as I can judge
Why is CodeCov not responding? Would be interesting to check the testing coverage in this case |
I want Oliver to actually check this in his settings, let's merge after he acks that it works for him.
good question, I've got no idea why it works as it works tbh. Maybe it doesn't care about merging to develop? ..............let's make our own with Julia'n'stuff? :D |
Codecov Report
@@ Coverage Diff @@
## develop #203 +/- ##
===========================================
+ Coverage 91.47% 93.76% +2.29%
===========================================
Files 11 8 -3
Lines 598 385 -213
===========================================
- Hits 547 361 -186
+ Misses 51 24 -27
Continue to review full report at Codecov.
|
Great - thx for fixing Codecov! |
So this actually seems to work just right on ULHPC so I'm going to fastforward a bit :D @oHunewald lmk in case you hit any issues. |
After the performance fixes in DistributedData (JuliaLang/julia#44671 (comment), LCSB-BioCore/DistributedData.jl#40 ) it no longer seems vital to maintain a custom clone of the functionality in GigaSOM. This switches to all functions from DistributedData.
In the process of cleaning I also axed
visualizations/
as they were not even included in the code (:rofl: ) and bumped to 0.7 so that people may start depending on this.There might be various leftovers from original gigasom-internal DiDa, esp in docs. I checked a lot with
sed
but still kinda betting on quality reviews. :D