Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogear pending accuracy tests #446

Merged
merged 2 commits into from
Apr 14, 2021
Merged

dogear pending accuracy tests #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a887632
dogear pending accuracy tests
elrayle Apr 14, 2021
9bfac26
update change log for v7.8.0 to include dogear of pending tests
elrayle Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### 7.8.0 (2021-04-14)

* add geographic subauth for Mesh-NLM
* dogear expected and actual cells when accuracy test is pending

### 7.7.1 (2021-04-14)

Expand Down
4 changes: 4 additions & 0 deletions app/assets/stylesheets/qa_server/_check-status.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ td.bold-left-border {
border-left: 2px solid black;
}

.status-dogear {
background: linear-gradient(135deg, #333 0%, #333 10%, transparent 10%, transparent 100%);
}

.status-good {
text-align: center;
background-color: #ccffcc;
Expand Down
2 changes: 1 addition & 1 deletion app/presenters/qa_server/check_status_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def comparison_status_data?

# @return [String] the name of the css style class to use for the status cell based on the status of the scenario test.
def status_style_class(status)
"status-#{status}"
status[:pending] ? "status-dogear status-#{status[:status]}" : "status-#{status[:status]}"
end

# @return [String] the name of the css style class to use for the status cell based on the status of the scenario test.
Expand Down
13 changes: 7 additions & 6 deletions app/views/qa_server/check_status/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@
<select name="authority" id="authority" class="string optional form-control form-control" value="" aria-labelledby="authority" onchange="hide_data()">
<option value=""><%= t('qa_server.check_status.select_authority') %></option>
<option disabled>──────────</option>
<option value="<%= @presenter.value_all_collections %>"><%= t('qa_server.check_status.show_all') %></option>
<option disabled>──────────</option>
<% @authorities_list.each do |auth_name| %>
<option value="<%= auth_name %>"<%= " selected" if auth_name == selected_authority %>><%= auth_name.upcase %></option>
<% end %>
Expand Down Expand Up @@ -77,7 +75,10 @@
<% end %>


<div id="status-loading-message" class="wait-message"><%= t('qa_server.check_status.wait_message') %></div>
<div id="status-loading-message" class="wait-message">
<%= t('qa_server.check_status.wait_message_ln1') %><br>
<%= t('qa_server.check_status.wait_message_ln2') %>
</div>

<% if @presenter.connection_status_data? %>
<div id="connection-status-section" class="status-section">
Expand All @@ -100,7 +101,7 @@
</tr>
<% end %>
<tr>
<td class="<%= @presenter.status_style_class(status[:status]) %>"><%= @presenter.status_label(status[:status]) %></td>
<td class="<%= @presenter.status_style_class(status) %>"><%= @presenter.status_label(status[:status]) %></td>
<td><%= status[:subauthority_name] %></td>
<td><%= status[:service] %></td>
<td><%= status[:action] %></td>
Expand Down Expand Up @@ -137,8 +138,8 @@
</tr>
<% end %>
<tr>
<td class="position <%= @presenter.status_style_class(status[:status]) %>"><%= status[:expected] %></td>
<td class="position <%= @presenter.status_style_class(status[:status]) %>"><%= status[:actual] %></td>
<td class="position <%= @presenter.status_style_class(status) %>"><%= status[:expected] %></td>
<td class="position <%= @presenter.status_style_class(status) %>"><%= status[:actual] %></td>
<td><%= status[:request_data] %></td>
<td><a href="<%= status[:target] %>"><%= status[:target] %></a></td>
<td><%= status[:authority_name] %></td>
Expand Down
4 changes: 2 additions & 2 deletions config/locales/qa_server.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ en:
check_status:
title: Check Status
select_authority: Select authority...
show_all: ALL Authorities (SLOW)
connections: Check Connection Status only
accuracy: Check Accuracy only
comparison: Compare Accuracy
all_checks: Run all checks
wait_message: "Please wait while the status is verified. This will be slow if you selected ALL Authorities."
wait_message_ln1: "Please wait while the status is verified."
wait_message_ln2: "This may be slow for large authorities or ones with a lot of tests."
connection_checks: Connection Checks
accuracy_checks: Accuracy Checks for Search Results
comparison_checks: Comparison of Accuracy Checks
Expand Down