Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap data-toggle for collapse failing #2147

Closed
jermnelson opened this issue Apr 21, 2020 · 3 comments · Fixed by #2148 or #2163
Closed

Bootstrap data-toggle for collapse failing #2147

jermnelson opened this issue Apr 21, 2020 · 3 comments · Fixed by #2148 or #2163
Labels
bug Something isn't working

Comments

@jermnelson
Copy link
Contributor

jermnelson commented Apr 21, 2020

Describe the bug
What went wrong? What did you expect to happen?
The SinopiaResourceTemplate's history function is now failing

<h3><button className="btn btn-link collapse-heading collapsed"
data-toggle="collapse" data-target="#historicalTemplates">Most recently used resource templates</button>
</h3>

These honeybadger alerts started after Monday's dependencies that updated the jQuery package to 3.5.0.

  • What is the impact on your work? (can't work / work stoppage; workaround exists; minor issue)
    Regression.

  • What environment are you in? (stage or production)
    Both

  • What OS and browser are you using? (Mac/Windows; Safari, Firefox, etc.)

  • If you're cataloging, what Resource Template were you using (name or ID)

Please include a screenshot
(Mac: shift-command-4; Windows: ; then drag the image file into the issue)
History-not-expanding

@jermnelson jermnelson added bug Something isn't working BFF labels Apr 21, 2020
@jcoyne
Copy link
Contributor

jcoyne commented Apr 21, 2020

Looks like twbs/bootstrap#30553

It's fixed here: twbs/bootstrap#30559 and we're waiting for 4.4.2 to be released

@jermnelson
Copy link
Contributor Author

Merging PR #2158, re-opens this bug with corresponding HoneyBadger alerts.

@jermnelson jermnelson reopened this May 5, 2020
@jcoyne
Copy link
Contributor

jcoyne commented May 6, 2020

jQuery 3.5.1 should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants