Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jQuery to v3.5.0. #30559

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Update jQuery to v3.5.0. #30559

merged 4 commits into from
Apr 17, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 11, 2020 •
edited
Loading

@XhmikosR XhmikosR mentioned this pull request Apr 11, 2020
Closed
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-jquery-340 branch 2 times, most recently from 8e4c77d to 1f3137f Compare April 11, 2020 15:28
@XhmikosR XhmikosR added the js label Apr 11, 2020
@XhmikosR XhmikosR marked this pull request as ready for review April 11, 2020 18:09
@XhmikosR XhmikosR requested a review from a team as a code owner April 11, 2020 18:09
@XhmikosR
Copy link
Member Author

I wonder if we should add the patch in master too even though it's not affected? It does make the intention clearer.

@Johann-S
Copy link
Member

We can make that change in v5, it make sense to me 👍

@XhmikosR XhmikosR mentioned this pull request Apr 12, 2020
Merged
@XhmikosR XhmikosR linked an issue Apr 13, 2020 that may be closed by this pull request
Bootstrap v4.4.1 collapse doesn't work with jQuery v3.5.0 #30553
Closed
@XhmikosR XhmikosR requested a review from Johann-S April 13, 2020 19:02
@PascalPixel
Copy link
Contributor

Did not check if we included it here, but could we also list jQuery and the specific version number as a dependency on our npm package?

@XhmikosR XhmikosR merged commit f5ec0db into v4-dev Apr 17, 2020
@XhmikosR XhmikosR deleted the v4-dev-xmr-jquery-340 branch April 17, 2020 08:41
@kulla kulla mentioned this pull request Apr 17, 2020
Closed
@et-nik et-nik mentioned this pull request Apr 18, 2020
Merged
quietly-turning added a commit to quietly-turning/Lua-For-SM5 that referenced this pull request Apr 19, 2020
@quietly-turning
npm update to jquery and bootstrap
6064c1e 
jQuery recently released v3.5.0 with a security patch for the internal
handling of closing tags.  See: https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

Allowing npm to upgrade jQuery to 3.5.0 revealed a bug with the current
version of bootstrap that would cause this SPA to crash when a user
clicked to collapse something, e.g. a sidebar section.

Bootstrap addressed this in twbs/bootstrap#30559
but there is not yet a Bootstrap release that includes this.  I'd previously
configured package.json to use release versions of Bootstrap (and all
dependencies).

To get the new Bootstrap fixes, I changed the package.json to use twbs's
GitHub repo for Bootstrap as outlined here:
https://docs.npmjs.com/files/package.json#github-urls

The update to Bootstrap has resulted in some minor oddities with this
app, but I'll address those in a separate commit.
5p4k added a commit to 5p4k/superscheda that referenced this pull request Apr 19, 2020
@5p4k
Downgrade jQuery to 3.4.1 because breaks bootstrap.
0a8e86a 
Cfr. twbs/bootstrap#30559 and twbs/bootstrap#30553
@jcoyne jcoyne mentioned this pull request Apr 21, 2020
Closed
@solarissmoke solarissmoke mentioned this pull request Apr 24, 2020
Closed
frnktrgr added a commit to frnktrgr/iptables2web that referenced this pull request Apr 26, 2020
@frnktrgr
Downgrade to jquery 3.4.x
6f17698 
See also twbs/bootstrap#30553. Waiting for
twbs/bootstrap#30559.
@DanFTRX
Copy link

DanFTRX commented Apr 28, 2020

@XhmikosR Is this patch going into the 3.x series as well? I hit this bug running bootstrap 3.4.1 with jQuery 3.5.0

@XhmikosR
Copy link
Member Author

No. v3 is EOL. But either way, the jQuery developers have already merged a fix on their side, they just need to release a patch version.

@DanFTRX
Copy link

DanFTRX commented Apr 28, 2020

@XhmikosR Yeah I just read that in the original ticket, the comments were "off-topic" so not originally viewable. Thanks for the response though!

@jcoyne jcoyne mentioned this pull request Apr 29, 2020
Closed
@cdmo cdmo mentioned this pull request May 1, 2020
Closed
@Siem2l Siem2l mentioned this pull request May 1, 2020
Merged
@peon501
Copy link

peon501 commented May 1, 2020

I use jquery v3.5.0 and Bootstrap v4.4.1 and it doesn't work with it.

@loic425 loic425 mentioned this pull request May 2, 2020
Merged
@mRoca mRoca mentioned this pull request May 3, 2020
Merged
@valadas valadas mentioned this pull request May 4, 2020
Closed
@jits jits mentioned this pull request May 4, 2020
Closed
@gatsinski gatsinski mentioned this pull request May 4, 2020
Merged
@inverse inverse mentioned this pull request May 5, 2020
Closed
@JamesQMurphy
Copy link

jQuery 3.5.1 is out and it fixed my UI issues.

@daraaleja
Copy link

jQuery 3.5.1 está fuera y solucionó mis problemas de IU.

Hello, sorry to bother you, I'm new to this topic but since you updated to 3.5.1, could you tell me the steps? thanks

spovich added a commit to AFI-Inc/bootstrap-sass that referenced this pull request May 21, 2020
@spovich
Backport bootstrap 4 fix for jQuery 3.5
3b09cd5 
* Bootstrap 4 issue: twbs/bootstrap#30553
* Bootstrap 4 fix: twbs/bootstrap#30559

Signed-off-by: John Dell <john@mutations.ltd>
@spovich spovich mentioned this pull request May 21, 2020
Closed
@JamesQMurphy
Copy link

jQuery 3.5.1 está fuera y solucionó mis problemas de IU.

Hello, sorry to bother you, I'm new to this topic but since you updated to 3.5.1, could you tell me the steps? thanks

In your package.json file, look for a line that says "jquery": "^3.5.0" and change the version number there.

@PascalPixel
Copy link
Contributor

Did not check if we included it here, but could we also list jQuery and the specific version number as a dependency on our npm package?

Unclear on why Bootstrap doesn't define its version in dependencies, but could you at least list the jQuery version as a peerDependency? That way there is at least a warning to use a certain version.

@IceWreck IceWreck mentioned this pull request Jun 29, 2020
Closed
FrankGrimm added a commit to FrankGrimm/omen that referenced this pull request Jul 7, 2020
@FrankGrimm
upgrade jQuery 3.5.0 to 3.5.1 twbs/bootstrap#30559
9f38381
@marxide marxide mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
dependencies js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap v4.4.1 collapse doesn't work with jQuery v3.5.0
7 participants
@XhmikosR @Johann-S @PascalPixel @DanFTRX @peon501 @JamesQMurphy @daraaleja