Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 3.5.0 breaks certain UI interactions (like dropdown menus) #177

Closed
jits opened this issue Apr 30, 2020 · 2 comments · Fixed by #179
Closed

jQuery 3.5.0 breaks certain UI interactions (like dropdown menus) #177

jits opened this issue Apr 30, 2020 · 2 comments · Fixed by #179
Assignees
Labels
bug Something isn't working javascript Pull requests that update Javascript code

Comments

@jits
Copy link
Contributor

jits commented Apr 30, 2020

A security update was recently committed – #176 – but this has broken certain UI interactions.

Need to go through the release notes and figure out what needs fixing – may need an upgrade to Bootstrap itself (as it's the Bootstrap components that are likely broken).

@jits jits self-assigned this Apr 30, 2020
@jits jits added bug Something isn't working javascript Pull requests that update Javascript code labels Apr 30, 2020
@jits
Copy link
Contributor Author

jits commented May 4, 2020

The jQuery folks are aware of this breaking change that is mainly affecting Bootstrap (for us) – rather than rolling back the fix on master I'm going to wait a couple of days to see if they release a fix.

(Note: we haven't yet pushed latest master to production yet so this isn't affecting the live site at the moment).

@jits
Copy link
Contributor Author

jits commented May 4, 2020

Looks like an upcoming v4.4.2 of Bootstrap should fix this – ref: twbs/bootstrap#30559.

So for now I'll revert the jQuery version bump on master and do all the necessary upgrades when the updates mentioned above are all ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant