Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jquery from 3.4.1 to 3.5.0 #565

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 30, 2020

Bumps jquery from 3.4.1 to 3.5.0.

Commits
  • 7a0a850 3.5.0
  • 8570a08 Release: Update AUTHORS.txt
  • da3dd85 Ajax: Do not execute scripts for unsuccessful HTTP responses
  • 065143c Ajax: Overwrite s.contentType with content-type header value, if any
  • 1a4f10d Tests: Blacklist one focusin test in IE
  • 9e15d6b Event: Use only one focusin/out handler per matching window & document
  • 966a709 Manipulation: Skip the select wrapper for <option> outside of IE 9
  • 1d61fd9 Manipulation: Make jQuery.htmlPrefilter an identity function
  • 04bf577 Selector: Update Sizzle from 2.3.4 to 2.3.5
  • 7506c9c Build: Resolve Travis config warnings
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by mgol, a new releaser for jquery since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [jquery](https://github.com/jquery/jquery) from 3.4.1 to 3.5.0.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](jquery/jquery@3.4.1...3.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 30, 2020
@cdmo
Copy link
Contributor

cdmo commented Apr 30, 2020

The failed specs appear to be there because of availability specs not getting what was expected. So I think this passes fine, but @banukutlu could you verify? We should make an issue to stub (maybe with Sinatra) the responses expected for availability feature specs?

@cdmo cdmo requested review from cdmo and banukutlu April 30, 2020 02:08
@cdmo cdmo added this to the 0.3.x Clean Up milestone Apr 30, 2020
cdmo
cdmo previously approved these changes Apr 30, 2020
@cdmo
Copy link
Contributor

cdmo commented May 1, 2020

twbs/bootstrap#30553

@cdmo
Copy link
Contributor

cdmo commented May 1, 2020

Looks like this issue will be resolved in Twitter Bootstrap 4.4.2 which is not yet released, see twbs/bootstrap#30559

See twbs/bootstrap#30692

@cdmo
Copy link
Contributor

cdmo commented May 1, 2020

Glad we had those feature specs in place to find this in CI! I am now watching releases on Twitter Bootstrap and we can try and upgrade when that's available.

@banukutlu
Copy link
Contributor

banukutlu commented May 1, 2020

The failed specs appear to be there because of availability specs not getting what was expected. So I think this passes fine, but @banukutlu could you verify? We should make an issue to stub (maybe with Sinatra) the responses expected for availability feature specs?

we talked about this on slack, so just to note here as well: these specs should not be failing, they fail because of the issue @cdmo mentioned:

twbs/bootstrap#30553

@banukutlu
Copy link
Contributor

Glad we had those feature specs in place to find this in CI! I am now watching releases on Twitter Bootstrap and we can try and upgrade when that's available.

yes exactly! and yeah we can upgrade when available 👍

Copy link
Contributor

@cdmo cdmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for release from TB

@cdmo
Copy link
Contributor

cdmo commented May 6, 2020

solved in #566

@cdmo cdmo closed this May 6, 2020
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@cdmo cdmo deleted the dependabot/npm_and_yarn/jquery-3.5.0 branch May 6, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants