Revert back to jQuery 3.4.1 to fix broken bootstrap menu #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Five days ago @dependabot proposed updating jQuery from 3.4.1 to 3.5.0. At first glance, everything worked and having trust in semantic versioning I accepted the pull request. Unfortunately, this caused an issue in Bootstrap and the collapsable mobile menu got broken. The project uses Bootstrap 4.3.1 but the problem exists even in the latest version 4.4.1. It is fixed 17 days ago in v4-dev but it's not released yet. We have to stick to jQuery 3.4.1 until the newer Bootstrap version is out.
I will merge this immediately in order to update the production environment. I believe there won't be any objection.
Here is a link to the issue: twbs/bootstrap#30553