[Security] Fixes for jQuery 3.5.0 #1210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bootstrap 4 issue: twbs/bootstrap#30553 * Bootstrap 4 fix: twbs/bootstrap#30559 Signed-off-by: John Dell <john@mutations.ltd>
spovich
changed the title
collapse.js for jQuery 3.5 (security)
spovich
changed the title
collapse.js for jQuery 3.5 (security)collapse.js for jQuery 3.5 (security)
spovich
changed the title
collapse.js for jQuery 3.5 (security)collapse.js for jQuery 3.5
* jQuery 3.5.0 changes access to `hasOwnProperty` Signed-off-by: John Dell <john@mutations.ltd>
spovich
changed the title
collapse.js for jQuery 3.5
spovich
changed the title
spovich
changed the title
|
This was fixed in jQuery 3.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collapse.jsproduces aCannot convert object to primitive valueJS error that is described in detail here: Bootstrap v4.4.1 collapse doesn't work with jQuery v3.5.0 bootstrap#30553 Backport the fix from Bootstrap 4 which is part of this larger PR: Update jQuery to v3.5.0. bootstrap#30559tooltip.jsandbootstrap.jsare both producing the errorTypeError: dataAttributes.hasOwnProperty is not a function. This issue was discussed here and their method for fixing the issue was used. UpdatehasOwnPropertycalls to use syntax compatible with jQuery 3.5.0It sounds like there is not going to be a 3.5.1 fix (maybe wait until 4.0), so this allows to safely upgrade to jQuery 3.5.0 with it's security update.