Updates to fix SimHits/Digi handling, follow enhances to the HGCROC emulator and corrections at Reco Level

[cmantill]

Solves #7

• Digitization:

  • Fix handling of SimHits so that SimHits that belong to a same bar are grouped together
  • Include the shift of a light-speed particle into the simhit time
  • Fix pulse parameter (timePeak) such that the pulse function peaks at t=0

• Reconstruction:

  • Use conditions system to provide chip parameters to emulator and reconstruction
  • Don't find maximum voltage in ADC Readout Mode, use SOI ADC measurement
  • Find TOA in sample (with respect to the SOI)
  • Apply correction to amplitude at Peak (based on the fraction of amplitude at Peak (t) / amplitude at t-1)
  • Apply time-walk correction to TOA (based on the corrected amplitude at Peak)
  • Set boundaries to corrections so that positions (derived from TOA differences) are not out of detector-bounds

• Tester

  • Enhance tester with a reconstructed position check (for now commented until next PhotoElectron studies are implemented) and an option to activate/de-activate saving an n-tuple.

[tomeichlersmith]

The tests are failing and it looks like you are just missing a line in your config(s):

https://github.com/LDMX-Software/ldmx-sw/runs/2363421931#step:9:107

Maybe just need to add import LDMX.Hcal.hcal_hardcoded_conditions somewhere?

[tomeichlersmith]

This is great! Besides the call for a little more documentation, I can't see anything else. Time to release the hounds and get to validating on larger samples!

[tomeichlersmith]

This is a perfect spot to put some documentation about how these corrections are calculated.

Using a multiline-doxygen comment, you'll have plenty of room and it will show up in the docs.

/**
 * Correction to the pulse amplitude.
 * This was calculated by...
 */

[cmantill]

Cool, thanks Tom! Just updated the docs