Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Conversation

@tomeichlersmith
Copy link
Member

Pretty basic stuff, figured since we have it formatted we should keep it formatted.

outline formatting and format-checking workflow

patch up to do a dry run and error out if format is failing

need to specify version of checkout action

allow for checking on any branches to test workflow

patch github actions check

use function instead of alias

move to one clang-format call so all format violations are reported at
once

patch docker call

have it be verbose so we can make sure its running
Copy link
Contributor

@EinarElen EinarElen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tomeichlersmith tomeichlersmith merged commit 5c8e7de into trunk Aug 18, 2023
@tomeichlersmith tomeichlersmith deleted the format-check-action branch August 18, 2023 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants