-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
…nto iss86PNModels
| * | ||
| **/ | ||
|
|
||
| virtual void incrementEventWeight(int N) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Would love some thoughts on this from others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a reasonable approach, its what I do with my signal stuff when only getting X events after N tries.
tomeichlersmith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We chatted in the sw-dev meeting about my only thoughts on this and our conclusion means that nothing needs to change here. I'm unsure if there are physics changes, but I think we can allow the ldmx-sw GitHub actions to check that for us after LDMX-Software/ldmx-sw#1160 is merged and new golden histograms are created with those (more helpful) histos.
So basically, I see
- merge this
- open PR in ldmx-sw updating SimCore after we update those histograms
- see if we need any patches
- make SimCore release if no more patches for this Hcal+PN stuff you've done
- update ldmx-sw with this work
|
Sounds reasonable to me. I'm going to sneak in a |
|
whoops, I got too excited and immediately after clicking the "make release" button I realized we had planned to do this after checking that it doesn't change anything. Whoops! I think I'll just plan to bump the patch number here in SimCore if we need to. |
|
For future reference, the feature is documented here: |
This PR does two things primarily and resolves #86, see some details on the motivation there
The other changes in SimCore are mostly in GammaPhysics, which has had its features moved into the PhotoNuclearModel functionality as well passing along the parameters from the runmanager.
I'm planning on documenting how to use these models and adding new ones over on the github pages later. There are some things one has to be careful about, but this PR gives you the tools you need to explore them. For example, to generate nothing hard events you want to only apply the model when interacting with heavy nuclei (at least copper), it is hard to make a nothing hard reaction from a smaller nucleus. Single neutron reactions on the other hand generally come from the primary collision they are relatively independent between different nuclei.
The toolset has been tested quite extensively by now, both from myself relying on it for the analysis that I showed at the CM & Lund focus talk, but I've also looked at some DQM figures e.g.