This repository was archived by the owner on May 6, 2024. It is now read-only.
Conversation
EinarElen
requested review from
cmantill and
tomeichlersmith
and removed request for
cmantill
3 tasks
cmantill
approved these changes
Apr 27, 2023
tomeichlersmith
approved these changes
Apr 27, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #91. We switch to using the hcal geometry condition to determine how to rotate pre/post steps into local coordinates.
Note:
This does change the behaviour for earlier Hcal geometries since the rotation will now be done correctly. This doesn't matter since we do not (and do not intend to) use the pre&post step information for these geometries.