Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Conversation

@tomeichlersmith
Copy link
Member

This PR is a few disparate patches related to my work studying the signal in the Ecal-as-Target analysis. They are relatively small changes that I have been using for several months and so I think it is fair to merge them in.

  1. Put another entry in the event header parameters corresponding to the elemental-Z of the dark brem interaction. It will be -1 if the dark brem did not occur. This is very helpful for analysis of a signal sample to make sure the distribution of elements on-which the dark brem occurred makes sense.
  2. Update G4DarkBreM to v2.0.0. This major release of G4DarkBreM was made to support multiple-Z dark brem reference libraries which is helpful for making the EaT signal more realistic as it is distributed across many materials with widely varying Z in elements.
  3. For the v14 detector, the ecal motherboards were not named in a way that was matched by the biasing operator attachment function so I patched that function to be able to pick up these volumes. They are thin PCB so including them does not affect the distributional shapes of any of the physics variables I was looking at, it just smoothed out the weight distribution a bit.

very small bug only noticeable when investigating the enriched nuclear
weight distribution in depth
was rebasing too quickly and didn't even stop to check if it compiled
Copy link
Contributor

@EinarElen EinarElen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely minor comment comment aside, this looks reasonable to me. Only thing would be the default -1 value which could cause some issues if someone isn't reading the docs and tries to do something like taking the average Z of all event headers but I can't think of a better option since it has to be stored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants