Make target PN bias configurable to 4 or 8 GeV beam energy. #1697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Target PN biasing is no longer hard-coded for a 4 GeV beam and now depends on the energy of the input generator, similar to how ECal PN biasing is done now.
Check List
I ran a test macro for a target PN simulation, with a similar run configuration as in the example script in LDCS.
Below is the RunHeader, showing that the correct biasing factor, threshold, and biased volume are applied for an input beam energy of 8 GeV.
I do, however, want to note that while the piece of code I'm modifying makes the correct change, my test script failed due to an unrelated issue: