Revert "Update CSV header to include timestamp and i_sample"

[tomeichlersmith]

Reverts #339

This was already done for the MultiSampleECONDEventPacket

pflib/src/pflib/packing/MultiSampleECONDEventPacket.cxx

Lines 10 to 40 in a8f5d5d

	const std::string MultiSampleECONDEventPacket::to_csv_header =
	"timestamp,orbit,bx,event,i_link,channel,i_sample,Tp,Tc,adc_tm1,adc,tot,"
	"toa";
	void MultiSampleECONDEventPacket::to_csv(std::ofstream& f) const {
	/**
	* The columns of the output CSV are
	* ```
	* timestamp,orbit,bx,event,i_link,channel,i_sample,Tp,Tc,adc_tm1,adc,tot,toa
	* ```
	*/
	for (std::size_t i_sample{0}; i_sample < samples.size(); i_sample++) {
	const auto& sample{samples[i_sample]};
	for (std::size_t i_link{0}; i_link < sample.links.size(); i_link++) {
	const auto& daq_link{sample.links[i_link]};
	f << timestamp << ',' << daq_link.orbit << ',' << daq_link.bx << ','
	<< daq_link.event << ',' << i_link << ',' << "calib," << i_sample
	<< ',';
	daq_link.calib.to_csv(f);
	f << '\n';
	for (std::size_t i_ch{0}; i_ch < 36; i_ch++) {
	f << timestamp << ',' << daq_link.orbit << ',' << daq_link.bx << ','
	<< daq_link.event << ',' << i_link << ',' << i_ch << ',' << i_sample
	<< ',';
	daq_link.channels[i_ch].to_csv(f);
	f << '\n';
	}
	}
	}
	}

I would like to revert this because the ECONDEventPacket::to_csv function does not write a timestamp or i_sample since it doesn't have access to that information.

pflib/src/pflib/packing/ECONDEventPacket.cxx

Lines 370 to 383 in a8f5d5d

	for (std::size_t i_link{0}; i_link < links.size(); i_link++) {
	const auto &daq_link{links[i_link]};
	f << i_link << ',' << daq_link.bx << ',' << daq_link.event << ','
	<< daq_link.orbit << ',' << "calib,";
	daq_link.calib.to_csv(f);
	f << '\n';
	for (std::size_t i_ch{0}; i_ch < 36; i_ch++) {
	f << i_link << ',' << daq_link.bx << ',' << daq_link.event << ','
	<< daq_link.orbit << ',' << i_ch << ',';
	daq_link.channels[i_ch].to_csv(f);
	f << '\n';
	}
	}
	}

If the decoding is not writing out the timestamp or i_sample, then its probably because somewhere needs to use MultiSampleECONDEventPacket instead of just ECONDEventPacket.

[tvami]

See my comment in
#339 (comment)

[tomeichlersmith]

Leaving this as draft since I'm not 100% confident and don't want to break decoding for folks while testbeam is going

[tomeichlersmith]

The issue was in econd_decoder.cxx which was using ECONDEventPacket::to_csv_header instead of MultiSampleECONDEventHeader::to_csv_header.

ecf4f60

Moreover, the current main gets the columns mixed up still. This only affects folks using econd-decoder with a RAW file. The live decoding and rogue decoding use the appropriate header.

eichl008@ldmxlab-Precision-3660:~/ldmx/pflib$ diff main.csv revert.csv 
1c1
< timestamp,i_link,bx,event,orbit,channel,i_sample,Tp,Tc,adc_tm1,adc,tot,toa
---
> timestamp,orbit,bx,event,i_link,channel,i_sample,Tp,Tc,adc_tm1,adc,tot,toa

[tomeichlersmith]

After making this patch, I realized that there is no situation where folks should be using ECONDEventPacket::to_csv so I'm removing it. Similar to DAQLinkFrame, ECONDEventPacket is purely an intermediate structure to aid in the decoding and logical access of the decoded data.