Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to namespaced tags, we also convert namespaced attributes into their corresponding ComponentTypes.
Otherwise, we get errors of this form:
A note here is that we lose namespace information, and if a loaded model is thus exported, it will be different from the imported text. Once the model has been loaded here, it has been "LEMSified", in the sense that it has been converted to LEMS's XML language, which does not support namespaces.
Thus, there should not be an expectation that a model loaded into PyLEMS will be exported in the same form. It will not.
I do not know if we want that to be the case. If we do, we will need to update our parsing to not strip out namespaces and so on.
I also have some queries regarding this code:
parse
method in LEMS.py uses ElementTree to load the XML text, but then creates theLEMSXMLNode
of it to process it.