Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for z_shift #110

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Fix for z_shift #110

merged 3 commits into from
Dec 1, 2020

Conversation

torbjone
Copy link
Collaborator

The z_shift that is used when the MoI method is used to calculate ECoG signals was broken in RecMEAElectrode class (see LFPy/LFPy#280).

@espenhgn
Copy link
Contributor

Hi @torbjone ; I think you have to allow Actions in your repository's Settings column on github

@espenhgn espenhgn added the bug fix fixes some issue label Nov 30, 2020
@espenhgn espenhgn added this to the Release 0.3 milestone Nov 30, 2020
@espenhgn
Copy link
Contributor

@espenhgn
Copy link
Contributor

@torbjone , can you please merge upstream changes from master? I've put coveralls testing in a separate step such that the Python application actions should run. Coveralls will most likely not work on your end. Please check the output of the Lintly flake8 checks for formatting issues if that also fails.

@espenhgn
Copy link
Contributor

@torbjone; I fixed the linting issues. Do you plan on pushing anything else?
I don't see anything in the PR that would break anything, so that's all swell.

Just ignore the coveralls error, can merge anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix fixes some issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants