feat(cli): add --no-console to autostart without a console window (#…

…598)

* feat(cli): autostart without a console window

This moves `komorebic` logic into a `lib.rs` file and calls it from `main.rs` (normal behavior) and then there is a second binary `komorebic-no-console` binary that uses `#![windows_subsystem = "windows"]` which tells the linker to not attach a console window to this binary.

* Revert "feat(cli): autostart without a console window"

This reverts commit 08494b4.

* feat(cli): autostart without a console window

This creates a second binary `komorebic-no-console` binary that uses `#![windows_subsystem = "windows"]` which tells the linker to not attach a console window to this binary and its only job is to run and pass its args to `komorebic`.

* add behind `--no-console` flag

* reference the new binary in wix

* remove no-console

* fix typo

.goreleaser.yml

@@ -26,6 +26,15 @@ builds:
       post:
         - mkdir -p dist/windows_amd64
         - cp ".\target\x86_64-pc-windows-msvc\release\komorebic.exe" ".\dist\komorebic_windows_amd64_v1\komorebic.exe"
+  - id: komorebic-no-console
+    main: dummy.go
+    goos: ["windows"]
+    goarch: ["amd64"]
+    binary: komorebic-no-console
+    hooks:
+      post:
+        - mkdir -p dist/windows_amd64
+        - cp ".\target\x86_64-pc-windows-msvc\release\komorebic-no-console.exe" ".\dist\komorebic_no_console_windows_amd64_v1\komorebic-no-console.exe"
 
 archives:
   - name_template: "{{ .ProjectName }}-{{ .Version }}-x86_64-pc-windows-msvc"

Cargo.toml

@@ -6,6 +6,7 @@ members = [
     "komorebi",
     "komorebi-core",
     "komorebic",
+    "komorebic-no-console",
 ]
 
 [workspace.dependencies]

komorebic-no-console/Cargo.toml

@@ -0,0 +1,15 @@
+[package]
+name = "komorebic-no-console"
+version = "0.1.19"
+authors = ["Jade Iqbal <jadeiqbal@fastmail.com>"]
+description = "The command-line interface (without a console) for Komorebi, a tiling window manager for Windows"
+categories = ["cli", "tiling-window-manager", "windows"]
+repository = "https://github.com/LGUG2Z/komorebi"
+license = "MIT"
+edition = "2021"
+
+# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+
+[dependencies]
+
+

komorebic-no-console/src/main.rs

@@ -0,0 +1,19 @@
+#![windows_subsystem = "windows"]
+
+use std::io;
+use std::os::windows::process::CommandExt;
+use std::process::Command;
+
+const CREATE_NO_WINDOW: u32 = 0x08000000;
+
+fn main() -> io::Result<()> {
+    let mut current_exe = std::env::current_exe().expect("unable to get exec path");
+    current_exe.pop();
+    let komorebic_exe = current_exe.join("komorebic.exe");
+
+    Command::new(komorebic_exe)
+        .args(std::env::args_os().skip(1))
+        .creation_flags(CREATE_NO_WINDOW)
+        .status()
+        .map(|_| ())
+}

komorebic/src/main.rs

@@ -1196,10 +1196,9 @@ fn main() -> Result<()> {
             );
         }
         SubCommand::EnableAutostart(args) => {
-            let mut current_exe_dir = std::env::current_exe().expect("unable to get exec path");
-            current_exe_dir.pop();
-
-            let komorebic_exe = current_exe_dir.join("komorebic.exe");
+            let mut current_exe = std::env::current_exe().expect("unable to get exec path");
+            current_exe.pop();
+            let komorebic_exe = current_exe.join("komorebic-no-console.exe");
             let komorebic_exe = dunce::simplified(&komorebic_exe);
 
             let startup_dir = startup_dir()?;

wix/main.wxs

@@ -92,6 +92,9 @@
             <Component Id='binary1' Guid='*'>
               <File Id='exe1' Name='komorebic.exe' DiskId='1' Source='$(var.CargoTargetBinDir)\komorebic.exe' KeyPath='yes' />
             </Component>
+            <Component Id='binary2' Guid='*'>
+              <File Id='exe2' Name='komorebic-no-console.exe' DiskId='1' Source='$(var.CargoTargetBinDir)\komorebic-no-console.exe' KeyPath='yes' />
+            </Component>
           </Directory>
         </Directory>
       </Directory>
@@ -108,6 +111,8 @@
 
       <ComponentRef Id='binary1' />
 
+      <ComponentRef Id='binary2' />
+
       <Feature Id='Environment' Title='PATH Environment Variable' Description='Add the install location of the [ProductName] executable to the PATH system environment variable. This allows the [ProductName] executable to be called from any location.' Level='1' Absent='allow'>
         <ComponentRef Id='Path' />
       </Feature>