Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: No way to configure Monitor Index Preference in json file? #522

Closed
GamalielMasters opened this issue Aug 23, 2023 · 3 comments
Closed

[BUG]: No way to configure Monitor Index Preference in json file? #522

GamalielMasters opened this issue Aug 23, 2023 · 3 comments
Assignees
@LGUG2Z
Labels
enhancement New feature or request

Comments

@GamalielMasters
Copy link

Describe the bug
I have looked through the json schema document and the documentation and can not find any information on setting the Monitor Index Preference values to map specific monitors to "rectangles" so their assignments don't migrate.

Expected behavior
To be able to configure the monitor index preference rectangles as part of the "monitors" key in the json config file.

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22621 N/A Build 22621

komorebic check Output

KOMOREBI_CONFIG_HOME detected: C:\Users\gamaliel.masters\.config\komorebi

Looking for configuration files in C:\Users\gamaliel.masters\.config\komorebi

No komorebi configuration found in C:\Users\gamaliel.masters\.config\komorebi

If running 'komorebic start --await-configuration', you will manually have to call the following command to begin tiling: komorebic complete-configuration

Additional context
I am still running key-bindings through AHK as I have not yet migrated them, but I don't think it applies to this issue.
@GamalielMasters GamalielMasters added the bug Something isn't working label Aug 23, 2023
@LGUG2Z LGUG2Z added enhancement New feature or request and removed bug Something isn't working labels Aug 24, 2023
@LGUG2Z
Copy link
Owner

LGUG2Z commented Aug 24, 2023

This will be added for the next release. 🤞

@LGUG2Z LGUG2Z closed this as completed in 363832f Aug 31, 2023
@LGUG2Z
Copy link
Owner

LGUG2Z commented Aug 31, 2023

This has now been added on the master branch and will be part of the next versioned release! 🎉

@LGUG2Z LGUG2Z self-assigned this Aug 31, 2023
@LGUG2Z
Copy link
Owner

LGUG2Z commented Sep 1, 2023

Live programming video of this being implemented: https://youtu.be/E4rL38lu94A

LGUG2Z added a commit that referenced this issue Sep 1, 2023
@LGUG2Z
feat(config): add monitor index prefs to static
d8892f3 
This commit adds an "monitor_index_preferences" key to the static config
schema, which was missed during the initial rollout of the static
configuration files. To help with testing, these indexes have also been
exposed on the State struct.

resolve #522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LGUG2Z LGUG2Z

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LGUG2Z @GamalielMasters