Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: double monocle a lone window on a desktop results in it having no container #758

Closed
raggi opened this issue Apr 14, 2024 · 1 comment
Labels
bug Something isn't working wm

Comments

@raggi
Copy link
Collaborator

raggi commented Apr 14, 2024

Describe the bug

If you toggle monocle twice on a window that is the sole window in the sole workspace on a monitor, the toggle on/off works (after the fix for the panic described in #757), but the monitor is left with no workspace, and the window is left orphaned, so it can no longer be focused by commands.

To Reproduce
Steps to reproduce the behavior:

  1. Open a single window on a single monitor
  2. Toggle monocle twice
  3. Focus a window on a second monitor
  4. Observe inability to focus original window, as there is no container in that direction
  5. Focus the orphaned window, observe inability to focus windows in other directions due to "no container"

Expected behavior
The window should have a container after it is restored from monocle.

Additional context
There is some kind of logic bug that would cause a panic, that is described in #757, that will be fixed independently - but may now further hide the bug.

@raggi raggi added bug Something isn't working wm labels Apr 14, 2024
raggi added a commit that referenced this issue Apr 14, 2024
This fixes the panic, but not the underlying problem.

Updates #757
Updates #758
raggi added a commit that referenced this issue Apr 14, 2024
This fixes the panic, but not the underlying problem.

Updates #757
Updates #758
@LGUG2Z
Copy link
Owner

LGUG2Z commented Apr 21, 2024

@RaptDept this is technically "fixed" here, but the fix could be improved:

6fce630

@LGUG2Z LGUG2Z closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wm
Projects
None yet
Development

No branches or pull requests

2 participants