-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error[E0277] when compiling komorebic #8
Comments
This is because the library used for generating the CLI, |
@crosstyan If you ever have errors in the future when compiling against a commit which has a passing GitHub Actions pipeline, you can click on the green tick and go to the top right of the page to download the |
The latest clap beta introduced a lot of breaking changes for komorebic, so I decided it was a good time to refactor a little and add documentation to all of the cli commands. The primary change for komorebic is that subcommands now only take structs as arguments, so every enum must be wrapped in a struct. Some macros have been introduced to ease this. Using on|off alongside enable|disable for BooleanState arguments has been deprecated, going forward only enable|disable will be supported. The commands to introduce float rules have been refactored to make use of ApplicationTarget, and a single command 'float-rule' has been introduced in the cli. Finally I took some time to standardise the sample AHK config a little, primarily making sure that command prompt windows are never shown for any of the configuration commands. BREAKING CHANGE: float-exe, float-class, and float-title have been deprecated in favour of float-rule in komorebic. workspace-tiling now only accepts enable|disable as valid inputs to the final arg, deprecating the previously also valid on|off. re #8
The latest clap beta introduced a lot of breaking changes for komorebic, so I decided it was a good time to refactor a little and add documentation to all of the cli commands. The primary change for komorebic is that subcommands now only take structs as arguments, so every enum must be wrapped in a struct. Some macros have been introduced to ease this. Using on|off alongside enable|disable for BooleanState arguments has been deprecated, going forward only enable|disable will be supported. The commands to introduce float rules have been refactored to make use of ApplicationTarget, and a single command 'float-rule' has been introduced in the cli. Finally I took some time to standardise the sample AHK config a little, primarily making sure that command prompt windows are never shown for any of the configuration commands. BREAKING CHANGE: float-exe, float-class, and float-title have been deprecated in favour of float-rule in komorebic. workspace-tiling now only accepts enable|disable as valid inputs to the final arg, deprecating the previously also valid on|off. re #8
When I'm compiling komorebic b2ab893 with
cargo install --path komorebic
I got complaints from compiler.The version of rustc is
1.54.0 (a178d0322 2021-07-26)
and komorebi was compiled successfully. Because I have no knowledge about Rust, I'm not sure what is going on.The text was updated successfully, but these errors were encountered: