feat(wm): apply workspace-rules to floating windows #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ds13
force-pushed
the
feature/workspace-rules-for-floating-windows
branch
from
fe7c4fa
to
bfee8ff
Compare
LGUG2Z
force-pushed
the
master
branch
8 times, most recently
from
12870dc
to
e46a1a6
Compare
LGUG2Z
reviewed
Oct 16, 2024
LGUG2Z
reviewed
Oct 16, 2024
| .floating_windows_mut() | ||
| .push(Window::from(op.hwnd)); | ||
| } else { | ||
| //TODO(alex-ds13): should this take into account the target workspace |
There was a problem hiding this comment.
I'm happy with this doing a plain insert creating a new container for now; this can be iterated on in the future if there is specific request
This commit allows `workspace-rules` and `initial_workspace_rules` to be applied to floating windows. As a by product of this commit, now the command to show `visible-windows` will now also show the maximized windows, monocled windows and floating windows.
alex-ds13
force-pushed
the
feature/workspace-rules-for-floating-windows
branch
from
bfee8ff
to
9f93ea0
Compare
|
I think this is good to merge now unless you want to add anything else? |
No. It's good for me too! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows
workspace-rulesandinitial_workspace_rulesto be applied to floating windows. As a by product of this commit, now the command to showvisible-windowswill now also show the maximized windows, monocled windows and floating windows.Should fix the issue #990
@LGUG2Z I know you wanted to handle the refactor of the
visible-windowstype of functions but since this one was needed for this PR I've already changed it...There are two
TODOcomments I added on this commit that I would like to have your feedback on.