feat(bar): add two new display format types

[alex-ds13]

This commit adds two new DisplayFormat types:

• TextAndIconOnSelected: which displays icon and text for the focused element and the other elements only have text.
• IconAndTextOnSelected: which displays icon and text for the focused element and the other elements only have icon.

Here's a picture that shows both types in action, the workspaces widget has the TextAndIconOnSelected and the focused window has the IconAndTextOnSelected:

Currently I've only setup this new types to the workspaces and focused_window widgets. Any other widget that uses DisplayFormat is probably ignoring these new types. If you find there is any other widget that makes sense to handle these types tell me and I can try adding them or they can be added later if someone asks for it.

[CtByte]

This was on my TODO as well :D

[alex-ds13]

This was on my TODO as well :D

One less TODO! 😄 Do you think this new display types need to be handled on any other widget, besides those two?

[CtByte]

I think it makes very good sense on these 2 (saving space) and it can be added to others later (but no other right now that would need it) 👍

@alex-ds13 My only comment on this PR would be to name the new options TextAndIconOnSelected and IconAndTextOnSelected, since you are setting whether or not a SelectableFrame is selected. What do you think?

[alex-ds13]

@alex-ds13 My only comment on this PR would be to name the new options TextAndIconOnSelected and IconAndTextOnSelected, since you are setting whether or not a SelectableFrame is selected. What do you think?

Makes sense to me! I'll change that...

[alex-ds13]

@LGUG2Z As mentioned on Discord, I've rebased this PR on top of #1177, this way you can merge this PR's without conflicts since all three PR's were changing things on the same files. This way the final order to merge should be the following:

1. feat(bar): scaled icon size relying on the font size #1184 (from @CtByte - makes icons have fixed sizes, which fixes a few issues, and adds some scaling to the icons)
2. feat(bar): optional workspaces on Komorebi widget #1177 (from me - makes the workspaces optional on Komorebi widget so that we can have workspaces on left_widgets and focus_window on center_widgets for example...)
3. feat(bar): add two new display format types #1176 (this PR - adds the display formats TextAndIconOnSelected and IconAndTextOnSelected)

[LGUG2Z]

Ah sorry, this might need another rebase; I updated the icon size commit message to include the context that was on the PR

[alex-ds13]

Ah sorry, this might need another rebase; I updated the icon size commit message to include the context that was on the PR

Should be good to go after #1177

[LGUG2Z]

Weird, I just merged in #1177 without touching it and now this one is again saying there are conflicts 🤔

[alex-ds13]

Weird, I just merged in #1177 without touching it and now this one is again saying there are conflicts 🤔

Weird I couldn't even rebase it to master since it considered it a noop and trying to force push would tell me that there was nothing to push. I guess the reason was that the commit on this PR had a different hash than the one on master... Although that's usually not a problem, at least not locally to me since when rebasing it can tell that they are the same commit and simply shows a message that it skipped a cherry-picked commit...

Maybe github can't or doesn't allow or isn't configured to do the same...

But now it should work.