Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation to make binding a display to a given index clearer #860

Closed
wants to merge 1 commit into from

Conversation

NireBryce
Copy link
Contributor

Hey, I had a hard time figuring out how to do this with what was posted in the github issues + documentation, so I wrote what I found.

I couldn't really discern style from the other workflow examples, but hopefully the common-workflow doesn't need much extra work to bring it to that.

(special thanks to javierportillo, who I do not know but found a usable config line via github codesearch)

@NireBryce
Copy link
Contributor Author

I couldn't find a way to discover the device id in the cli reference, so I used komorebic state | findstr -I -N device_id

LGUG2Z added a commit that referenced this pull request Jun 1, 2024
This commit adds a new monitor-information command to make it easier for
people to find the values they need to use the display_index_preferences
configuration option.

re #860
@LGUG2Z
Copy link
Owner

LGUG2Z commented Jun 2, 2024

Made a couple of changes and merged this via the CLI here: 3f6e19b

I added a command in another commit to print display IDs and size info directly which I referenced in the new docs page you created.

As for the examples, I think we should add these but we need to plumb them through like this: https://graham.cool/schemars/deriving/attributes/#example

Otherwise they will get blown away every time just schemagen gets run to prepare for new releases

@LGUG2Z LGUG2Z closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants