Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different dataset sizes cause list out of range error on OfficeHome experiment #17

Closed
mingxilei opened this issue Jan 18, 2024 · 1 comment

Comments

@mingxilei
Copy link

The error is noticed when adapting models from source domain realworld to target domain art. Domain art has smaller size of data.

In your source code (ttab.loads.datasets.dataset.py line 332), the method to load a target domain is to load the source domain first, then replace the data and targets (ttab.loads.datasets.dataset_shift.py). The data_size and indices are not updated, so len(dataset.data) != len(dataset). The iterator still uses larger indices of realworld to get items so it cause that error.

MarcellusZhao added a commit that referenced this issue Mar 9, 2024
@MarcellusZhao
Copy link
Collaborator

Thank you for identifying this issue. This issue has been fixed! So I'll close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants