Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Lit Action Conditions: Reading State from Stellar example #272

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spacesailor24
Copy link
Contributor

This PR inits a guide to showcase reading state from the Stellar blockchain to provide access control for decryption

There's a PR for the code used in this guide here

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for lit-dev-docs ready!

Name Link
🔨 Latest commit c6932fc
🔍 Latest deploy log https://app.netlify.com/sites/lit-dev-docs/deploys/662ae423391a860008d7f3d1
😎 Deploy Preview https://deploy-preview-272--lit-dev-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@joshLong145 joshLong145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsut minor stuff. nice job! will approve but please address the two inline comments

The first thing we need to do is create a Lit Client connected to the `habanero` network:

```javascript
const client = new LitJsSdk.LitNodeClientNodeJs({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const client = new LitJsSdk.LitNodeClientNodeJs({
const client = new LitNodeClientNodeJs({

Comment on lines +77 to +81
const domain = "localhost";
const origin = "https://localhost/login";
const statement =
"This is a test statement. You can put anything you want here.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add something to this guide that says that the user should configure these to there web application context? These should be configured by the DApp developer.

@spacesailor24 spacesailor24 marked this pull request as draft May 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants