Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 3.1.0 release - Feat/manzano habanero #318

Merged
merged 54 commits into from
Jan 26, 2024
Merged

Conversation

Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Jan 22, 2024

Description

This PR includes:

  • RLI Delegation
  • Re-try mechanism
  • Manzano & Habanero networks

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Code to run

NETWORK=habanero MINT_NEW=true DEBUG=true yarn test:e2e:node --group=rli         
  • e2e-nodejs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Josh Long and others added 14 commits December 15, 2023 17:14
This reverts commit f900e15.
* connect to all nodes, fix kicked nodes filtering

* fix 2-sigs test

---------

Co-authored-by: Josh Long <josh@litprotocol.com>
* wip

* wip

* wip

* wip

* Support for contract resolver  for resolving addresses

* add e2e tests

* reduced contract resolve

* remove e2e test for unit test impl

* fix for type normalizing

* fmt

* run ci on all branches

* run ci oon pull requests

* change branch rules in workflow

* dont duplciate test runs on prs
@Ansonhkg Ansonhkg requested a review from joshLong145 as a code owner January 22, 2024 21:52
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ joshLong145
✅ glitch003
✅ Ansonhkg
❌ Adarsh-Kumar28
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@joshLong145 joshLong145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some questions on a couple test changes and comments on removing internal dev as a network option.

packages/constants/src/lib/enums.ts Outdated Show resolved Hide resolved
packages/core/src/lib/lit-core.ts Outdated Show resolved Hide resolved
packages/core/src/lib/lit-core.ts Outdated Show resolved Hide resolved
packages/core/src/lib/lit-core.ts Outdated Show resolved Hide resolved
packages/types/src/lib/types.ts Outdated Show resolved Hide resolved
@Ansonhkg Ansonhkg requested a review from joshLong145 January 22, 2024 23:44
packages/contracts-sdk/src/lib/contracts-sdk.ts Outdated Show resolved Hide resolved
packages/contracts-sdk/src/lib/contracts-sdk.ts Outdated Show resolved Hide resolved
packages/contracts-sdk/src/lib/contracts-sdk.ts Outdated Show resolved Hide resolved
packages/contracts-sdk/src/lib/contracts-sdk.ts Outdated Show resolved Hide resolved
packages/contracts-sdk/src/lib/contracts-sdk.ts Outdated Show resolved Hide resolved
packages/contracts-sdk/src/lib/contracts-sdk.ts Outdated Show resolved Hide resolved
Bean and others added 4 commits January 24, 2024 18:51
…ndpoints (#307)

* wip retry agent

* tweak logging

* fix signature share combining

* tweak retry logic for failure detection

* add standard error logging

* add validation error

* fmt

* tweak to new signaure share processing

* add retry to network operations

* refactor retry for multi request tracking

* refactor for group request retry

* add uint tests for executeWithRetry

* fmt

* updates from review comments

* fmt

* fmt

* fix validateAndSignEcdsa retry logic

* remove logging

* fmt

* remove logging of provider object

* support removing circular refs when serializing objects

* move _safeStringify up for reuse

* Revert "remove logging of provider object"

This reverts commit 0844930.

* Revert "move _safeStringify up for reuse"

This reverts commit d8a15e5.

* Revert "support removing circular refs when serializing objects"

This reverts commit 393bb6e.

* Test/Encryption and decryption using the PKP as the requesting wallet (#312)

* add e2e test using the pkp to encrypt and decrypt instead of using a user provided wallet

* fmt

* fix typings

* refactor to no longer use request id when logging errors being retried

* refactor to not use trace id when logging retry on error

* fmt

* Feature/lit 2183 error with checkandsignauthmessage (#311)

* remove logging of provider object

* support removing circular refs when serializing objects

* move _safeStringify up for reuse

* fmt

* add comment to _safeStringify

* fix unused var

* auto-gen

* Publish 3.0.30

* feat: support session sigs when get auth method id

* revert to 05684c6 (#314)

* Publish 3.0.31

* fmt

* feature/lit-2303-js-sdk-authmethod-is-a-sessionsig-if-so-parse-one-of-the (#316)

* AuthMethod is a sessionSig if so parse one of the elements of it's array

* update comment

* nit: I think we could do this with a single  loop

* fmt

* feat: Support Scroll mainnet (#317)

* fix typeo

* Fix/failing unit tests (#321)

* fix failing unit tests

* fmt

* wip retry agent

* tweak logging

* fix signature share combining

* tweak retry logic for failure detection

* add standard error logging

* add validation error

* fmt

* tweak to new signaure share processing

* add retry to network operations

* refactor retry for multi request tracking

* refactor for group request retry

* add uint tests for executeWithRetry

* fmt

* updates from review comments

* fmt

* fmt

* fix validateAndSignEcdsa retry logic

* remove logging

* fmt

* fix typings

* refactor to no longer use request id when logging errors being retried

* refactor to not use trace id when logging retry on error

* fmt

* remove logging of provider object

* support removing circular refs when serializing objects

* move _safeStringify up for reuse

* Revert "remove logging of provider object"

This reverts commit 0844930.

* Revert "move _safeStringify up for reuse"

This reverts commit d8a15e5.

* Revert "support removing circular refs when serializing objects"

This reverts commit 393bb6e.

* Publish 3.0.30

* Test/Encryption and decryption using the PKP as the requesting wallet (#312)

* add e2e test using the pkp to encrypt and decrypt instead of using a user provided wallet

* fmt

* Feature/lit 2183 error with checkandsignauthmessage (#311)

* remove logging of provider object

* support removing circular refs when serializing objects

* move _safeStringify up for reuse

* fmt

* add comment to _safeStringify

* fix unused var

* auto-gen

* feat: support session sigs when get auth method id

* revert to 05684c6 (#314)

* Publish 3.0.31

* fmt

* feature/lit-2303-js-sdk-authmethod-is-a-sessionsig-if-so-parse-one-of-the (#316)

* AuthMethod is a sessionSig if so parse one of the elements of it's array

* update comment

* nit: I think we could do this with a single  loop

* fmt

* feat: Support Scroll mainnet (#317)

* fix typeo

* Fix/failing unit tests (#321)

* fix failing unit tests

* fmt

* rebase to feat/habanero-manzano

* fmt

* Feature/lit 2237 implement retry operations for stateless threshold endpoints feat/manzano habanero (#324)

* Resolved conflicts

* fix: no rli test

---------

Signed-off-by: Anson <ansonox@gmail.com>
Co-authored-by: Federico Amura <federicoamura@gmail.com>
Co-authored-by: Ansonhkg <ansonox@gmail.com>
Co-authored-by: Adarsh-Kumar28 <115020815+Adarsh-Kumar28@users.noreply.github.com>
@joshLong145 joshLong145 mentioned this pull request Jan 25, 2024
Ansonhkg and others added 14 commits January 25, 2024 22:08
* WIP

* polish up

* conditionally adding property

* remove console.log
* port utility code for now to make contract-sdk auth parsing fully functional

* fmt

---------

Signed-off-by: Anson <ansonox@gmail.com>
Co-authored-by: Anson <ansonox@gmail.com>
* add other network options

* Revert "add other network options"

This reverts commit ba94cd6.

* add other network options
joshLong145
joshLong145 previously approved these changes Jan 26, 2024
@joshLong145 joshLong145 merged commit dccdaf8 into master Jan 26, 2024
1 of 4 checks passed
@joshLong145 joshLong145 deleted the feat/manzano-habanero branch January 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants