-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ipfsHash helper #713
Open
Ansonhkg
wants to merge
7
commits into
master
Choose a base branch
from
feat/add-ipfs-hash-helper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+200
−70
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b4d65b2
feat: add ipfsHash helper
Ansonhkg ef12124
fmt
Ansonhkg a3a138a
Merge branch 'master' into feat/add-ipfs-hash-helper
Ansonhkg d3f9ac9
Merge branch 'master' into feat/add-ipfs-hash-helper
Ansonhkg 3a4cd13
Merge branch 'master' into feat/add-ipfs-hash-helper
Ansonhkg feea7c9
Merge branch 'master' into feat/add-ipfs-hash-helper
Ansonhkg af3f0c5
Update packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts
Ansonhkg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ import { computeAddress } from '@ethersproject/transactions'; | |
import { BigNumber, ethers } from 'ethers'; | ||
import { sha256 } from 'ethers/lib/utils'; | ||
import { SiweMessage } from 'siwe'; | ||
import * as Hash from 'typestub-ipfs-only-hash'; | ||
|
||
import { | ||
LitAccessControlConditionResource, | ||
|
@@ -662,40 +663,8 @@ export class LitNodeClientNodeJs | |
}; | ||
|
||
// ========== Promise Handlers ========== | ||
getIpfsId = async ({ | ||
dataToHash, | ||
sessionSigs, | ||
}: { | ||
dataToHash: string; | ||
sessionSigs: SessionSigsMap; | ||
debug?: boolean; | ||
}) => { | ||
const res = await this.executeJs({ | ||
ipfsId: LIT_ACTION_IPFS_HASH, | ||
sessionSigs, | ||
jsParams: { | ||
dataToHash, | ||
}, | ||
}).catch((e) => { | ||
logError('Error getting IPFS ID', e); | ||
throw e; | ||
}); | ||
|
||
let data; | ||
|
||
if (typeof res.response === 'string') { | ||
try { | ||
data = JSON.parse(res.response).res; | ||
} catch (e) { | ||
data = res.response; | ||
} | ||
} | ||
|
||
if (!data.success) { | ||
logError('Error getting IPFS ID', data.data); | ||
} | ||
|
||
return data.data; | ||
getIpfsId = async ({ str }: { str: string }): Promise<`Qm${string}`> => { | ||
return (await Hash.of(Buffer.from(str))) as `Qm${string}`; | ||
}; | ||
|
||
/** | ||
|
@@ -727,10 +696,17 @@ export class LitNodeClientNodeJs | |
); | ||
} | ||
|
||
if (!params.code) { | ||
return throwError({ | ||
message: 'code is required', | ||
errorKind: LIT_ERROR.INVALID_PARAM_TYPE.kind, | ||
errorCode: LIT_ERROR.INVALID_PARAM_TYPE.name, | ||
}); | ||
Comment on lines
+700
to
+704
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As this PR is pointing to master (v7) it should be updated to use the new errors |
||
} | ||
|
||
// determine which node to run on | ||
const ipfsId = await this.getIpfsId({ | ||
dataToHash: params.code!, | ||
sessionSigs: params.sessionSigs, | ||
str: params.code, | ||
}); | ||
|
||
// select targetNodeRange number of random index of the bootstrapUrls.length | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were we using a LA for this? Seems like a tremendous overkill