Partially fix issue #37 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpottier
force-pushed
the
bugfix/python-package-install
branch
from
358ff28 to
c8f76a0
Compare
…AMS python package. Does not fix the possible useless re-install. Also fix a forgotten useless copy in surrogate model from PR #49 Signed-off-by: Loic Pottier <pottier1@llnl.gov>
lpottier
force-pushed
the
bugfix/python-package-install
branch
from
c8f76a0 to
f857803
Compare
|
This looks good to me. Since you are at it. Can you go also go here and make those references as well? |
koparasy
approved these changes
Feb 27, 2024
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
|
@koparasy I have fixed the missing references |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.toml