Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packing test for AMS #64

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Packing test for AMS #64

wants to merge 1 commit into from

Conversation

koparasy
Copy link
Member

@koparasy koparasy commented Apr 4, 2024

No description provided.

@koparasy koparasy requested a review from lpottier April 4, 2024 16:03
Copy link
Collaborator

@lpottier lpottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ready to merge when that cpu_packing test is fixed.

s_data.clear();
sr_data.clear();
d_data.clear();
cudaDeviceReset();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call cudaDeviceReset() to seems to be problematic on the CI side but works fine on LC machines for some reasons. We can just add:

#include "cuda.h"
#include "cuda_runtime.h"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should guard it with ENABLE_CUDA. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants