Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/json #67

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Features/json #67

merged 8 commits into from
Jun 4, 2024

Conversation

koparasy
Copy link
Member

No description provided.

koparasy added 4 commits May 1, 2024 17:53
…interface.

* Removed template of basedb, only store mechanism now is templated.
* In this version db interfaces can be initialized only by environment
* misses support to use the json declared models
…stract models and

associate domain function pointers with the said ml models.

* Initial support for registering ml-models through JSON files
* Initial support for querrying the models from application side
* Extended tests
@koparasy
Copy link
Member Author

@ggeorgakoudis can we update our images to include nlohmann/json. AFAIK there is the nlohmann-json spack package.

@ggeorgakoudis
Copy link
Member

@ggeorgakoudis can we update our images to include nlohmann/json. AFAIK there is the nlohmann-json spack package.

Yes, certainly, there is a package. I'll ping when they're uploaded.

@koparasy
Copy link
Member Author

Coming back to it:

import sys
import torch
from pathlib import Path
import pandas as pd
import h5py
import numpy as np

Following up on our verbal discussion. These are the packages we use to verify tests. I am not sure about h5py and pandas. Can you ensure the inclusion of those in the new image,

@koparasy koparasy marked this pull request as ready for review May 24, 2024 22:14
src/AMSlib/include/AMS.h Outdated Show resolved Hide resolved
src/AMSlib/ml/surrogate.hpp Outdated Show resolved Hide resolved
src/AMSlib/ml/surrogate.hpp Show resolved Hide resolved
src/AMSlib/ml/uq.hpp Show resolved Hide resolved
src/AMSlib/ml/uq.hpp Outdated Show resolved Hide resolved
tests/AMSlib/torch_model.cpp Show resolved Hide resolved
tests/AMSlib/verify_ete.py Outdated Show resolved Hide resolved
src/AMSlib/AMS.cpp Outdated Show resolved Hide resolved
src/AMSlib/AMS.cpp Outdated Show resolved Hide resolved
src/AMSlib/include/AMS.h Show resolved Hide resolved
Copy link
Member

@ggeorgakoudis ggeorgakoudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment to address optionally

tests/AMSlib/torch_model.cpp Show resolved Hide resolved
@koparasy koparasy merged commit 7bccc05 into develop Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants