This commit addresses multiple problems in the broker part of AMS #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we are not sending input/output as encoded string anymore, we send binary blobs - base64 has been removed - a bug has been fixed with (very) old libevent version (<= 2.0.21-stable) - offloading inputs/outputs to the thread managing RMQ is now much faster Signed-off-by: Loic Pottier <pottier1@llnl.gov>
koparasy
reviewed
Sep 20, 2023
koparasy
requested changes
Nov 2, 2023
There was a problem hiding this comment.
@lpottier The PR look really good. Good job. I went through and commented mainly style changes. I will go deeper tomorrow and follow the architecture and the underlying logic. The PR will benefit if you add a high level description of the process. Briefly introducing the RMQ concept to a new developer. Thanks!
…rt pointers. Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
…code. Signed-off-by: Loic Pottier <pottier1@llnl.gov>
… ResourceManager::copy Signed-off-by: Loic Pottier <pottier1@llnl.gov>
lpottier
force-pushed
the
bugfix/rabbitmq_perf
branch
from
5efbc01 to
d9c2bed
Compare
koparasy
approved these changes
Nov 7, 2023
koparasy
pushed a commit
that referenced
this pull request
Nov 7, 2023
* This commit addresses multiple problems in the broker part of AMS - we are not sending input/output as encoded string anymore, we send binary blobs - base64 has been removed - a bug has been fixed with (very) old libevent version (<= 2.0.21-stable) - offloading inputs/outputs to the thread managing RMQ is now much faster * Moved to ResourceManager, created AMSMessage structures, moved to smart pointers. * Complete re-design of the RabbitMQ backend * Removed EventBuffer, removed pthread and signals. Big cleanup of the code. * Added documentation and new AMSMsgHeader class + moved from memcpy to ResourceManager::copy
koparasy
pushed a commit
that referenced
this pull request
Nov 9, 2023
* This commit addresses multiple problems in the broker part of AMS - we are not sending input/output as encoded string anymore, we send binary blobs - base64 has been removed - a bug has been fixed with (very) old libevent version (<= 2.0.21-stable) - offloading inputs/outputs to the thread managing RMQ is now much faster * Moved to ResourceManager, created AMSMessage structures, moved to smart pointers. * Complete re-design of the RabbitMQ backend * Removed EventBuffer, removed pthread and signals. Big cleanup of the code. * Added documentation and new AMSMsgHeader class + moved from memcpy to ResourceManager::copy
koparasy
pushed a commit
that referenced
this pull request
Nov 10, 2023
* This commit addresses multiple problems in the broker part of AMS - we are not sending input/output as encoded string anymore, we send binary blobs - base64 has been removed - a bug has been fixed with (very) old libevent version (<= 2.0.21-stable) - offloading inputs/outputs to the thread managing RMQ is now much faster * Moved to ResourceManager, created AMSMessage structures, moved to smart pointers. * Complete re-design of the RabbitMQ backend * Removed EventBuffer, removed pthread and signals. Big cleanup of the code. * Added documentation and new AMSMsgHeader class + moved from memcpy to ResourceManager::copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PthreadsThe structure of the binary messages that we send is documentation in the code.