Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/ams new interface #92

Open
wants to merge 63 commits into
base: develop
Choose a base branch
from
Open

Features/ams new interface #92

wants to merge 63 commits into from

Conversation

koparasy
Copy link
Member

@koparasy koparasy commented Dec 24, 2024 •
edited
Loading

This PR adds the new interface, and allows AMS to read in "Tensors".

Pending Tasks:

  • update examples
  • support rmq for tensors
  • update CI to reflect the changes
    • Update gitlab CI
    • Update github CI
    • Enable RMQ CI
  • Convert examples as external packages. Allowing to link in properly AMS
  • Add tests in which we link as an external project (not the way we do now).
  • Edit the main cmake file
  • Generate models at configure time, instead of build time.
  • Distributed executions should be put back in cause of update-model.

koparasy added 30 commits November 8, 2024 11:03
@koparasy
Add 'small' containers from LLVM
f826433
@koparasy
Impelements AMS-tensor interface
b53eceb
@koparasy
Fix compilation issues
445010e
@koparasy
Concat test case 1, works
fba42ac
@koparasy
Expand is working
747321b
@koparasy
Remove C++14 for cuda
f58b07e
@koparasy
Fix tensor concat
38b7c09
@koparasy
Simplified surrogate interfaces by assuming pytorch support, improves…
8de50c5 
… testing
@koparasy
Updated basedb-hdf5
b6e616f
@koparasy
Simple test for db manager
7413451
@koparasy
Added tensor aware workflow
a6fdbad
@koparasy
Tests scatter
01ccc6f
@koparasy
Re structuring files
3e0df58
@koparasy
Implement tensor aware workflow
27797aa
@koparasy
Compiling new interface
7a00b80
@koparasy
Fixing integration tests
8a16d21
@koparasy
Fixed interface
5fd65bd
@koparasy
Handle correct 2D inout tensors
4342357
@koparasy
Adding 2d test
4d9e06a
@koparasy
Add broadcast test
d7b0c2b
@koparasy
Nit fixes
5d0c960
@koparasy
Remove faiss from cmake
3418667
@koparasy
Remove redis from cmake
aa74723
@koparasy
Enable DB is always on
1a13cab
@koparasy
Delete models and clean up amslib test directory
d524e2e
@koparasy
Remove dependencies on umpire
26dea30
@koparasy
Remove cuda specific compilations
0f46d9f
@koparasy
Clean up cmake
b3e1ed5
@koparasy
Adopt new interface on ideal gas
c059edb
@koparasy
Update tests for gitlab
7e8fd06
@koparasy koparasy requested a review from lpottier January 4, 2025 01:32
@koparasy
Copy link
Member Author

koparasy commented Jan 4, 2025

@lpottier I assigned you as a reviewer. This is a complete refactor. I redid many points. In any case reviewing the changes will be hard, I understand. Would you like maybe to setup some meeting and do a code walk through? Let me know.

koparasy
koparasy commented Jan 14, 2025
View reviewed changes
CMakeLists.txt
list(APPEND AMS_APP_LIBRARIES umpire)
list(APPEND AMS_APP_INCLUDES ${UMPIRE_INCLUDE_DIR})

find_package(nlohmann_json REQUIRED)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should always find package in the AMSConfig.cmake.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpottier lpottier Awaiting requested review from lpottier

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koparasy