Improvements to ArrayView interface #221
Conversation
adayton1
commented
Apr 11, 2023
•
adayton1
commented
- Adds ArrayView aliases
- Adds factory functions for making const views
| using ArrayView1D = RAJA::View<T, RAJA::Layout<1>>; | ||
|
|
||
| template <class T> | ||
| using ArrayCView1D = ArrayView1D<const T>; |
There was a problem hiding this comment.
This is nit picky, but why did you call this ArrayCView1D rather than ArrayViewC1D (Array View Constant 1D) or CArrayView1D (Constant Array View 1D)?
There was a problem hiding this comment.
I guess elsewhere you call this a const view so maybe that makes sense nvm
There was a problem hiding this comment.
I was actually going to ask what you think of the naming. Would it make sense to drop "Array" from the naming scheme and just have View1D, ConstView1D, View2D, ConstView2D, etc...?
There was a problem hiding this comment.
That makes sense. We have RAJA::View, so having care::View would be consistent and it would be clear as long as it is in the care namespace. Spelling out Constant makes things clear also, harder to miss the difference. But I would ask some of the others before making a sweeping change.
There was a problem hiding this comment.
This isn't used anywhere yet, so now is a great time to make changes.
