Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Design review (for API changes or additions---delete if unneeded)
We have not yet done a design review.
I wanted to get this started before taking off. In Kokkos, we've managed to isolate the vast majority of the plumbing to allow Kokkos Tools to operate in other programming models, including RAJA (this PR).
What would need to be done to bring this to production would be
RAJA::initialize(argc, argv)
and just use our arg-parsing) before callingKokkos::Tools::initialize
RAJA::forall<cuda_autotuning_exec>
, which will by the way work with your Apollo tool if you implement it with Kokkos Toolsimpl/
in include, because I get CMake errors if I put them ininclude/RAJA/tools/impl
Anyway, this is something you could work on with the Kokkos team, if it's of interest