Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos Tools first attempt #1158

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DavidPoliakoff
Copy link
Contributor

Summary

  • This PR is a feature
  • It does the following (modify list as needed):
    • Adds partial support for Kokkos Tools to RAJA

Design review (for API changes or additions---delete if unneeded)

We have not yet done a design review.

I wanted to get this started before taking off. In Kokkos, we've managed to isolate the vast majority of the plumbing to allow Kokkos Tools to operate in other programming models, including RAJA (this PR).

What would need to be done to bring this to production would be

  • Plumb however you load tools in with how we do it. If you have an environment variable you recommend people set to load a tool, populate the Kokkos::Tools::InitArguments with it (or ask people to call RAJA::initialize(argc, argv) and just use our arg-parsing) before calling Kokkos::Tools::initialize
  • Possibly start using this with your named kernel facilities
  • For something crazy high-impact, add autotuning. RAJA::forall<cuda_autotuning_exec>, which will by the way work with your Apollo tool if you implement it with Kokkos Tools
  • Fix the build system weirdness. I put the header files in impl/ in include, because I get CMake errors if I put them in include/RAJA/tools/impl

Anyway, this is something you could work on with the Kokkos team, if it's of interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant