Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin atomic fixes for 32 bit windows #1746

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Builtin atomic fixes for 32 bit windows #1746

merged 2 commits into from
Oct 14, 2024

Conversation

adayton1
Copy link
Member

Summary

@adayton1 adayton1 mentioned this pull request Sep 27, 2024
Closed
@adayton1
Copy link
Member Author

@kennyweiss, can you check if this branch fixes the compilation issues you were seeing?

@kennyweiss
Copy link
Member

Thanks @adayton1 -- I confirmed that this fixes the issue in x86 configurations of axom.

kennyweiss
kennyweiss approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adayton1 !

@adayton1 adayton1 merged commit 0edd83c into develop Oct 14, 2024
26 checks passed
@adayton1 adayton1 deleted the bugfix/dayton8/win32 branch October 14, 2024 20:40
@kennyweiss kennyweiss mentioned this pull request Oct 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@MrBurmark MrBurmark MrBurmark approved these changes

@rhornung67 rhornung67 Awaiting requested review from rhornung67

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSVC compilation failure w/ 64-bit intrinsics in x86 configurations
4 participants
@adayton1 @kennyweiss @MrBurmark @rhornung67