EDGE3D App #300
Merged
EDGE3D App #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
reviewed
Feb 13, 2023
artv3
reviewed
Feb 13, 2023
artv3
approved these changes
Feb 13, 2023
CRobeck
reviewed
Feb 14, 2023
pguthrey
force-pushed
the
feature/guthrey1/edge3d
branch
from
fd770a7 to
5ec234a
Compare
MrBurmark
reviewed
Feb 17, 2023
MrBurmark
reviewed
Feb 17, 2023
MrBurmark
reviewed
Feb 17, 2023
|
Todo: investigate launch bounds. |
MrBurmark
reviewed
Feb 17, 2023
artv3
reviewed
Feb 17, 2023
pguthrey
force-pushed
the
feature/guthrey1/edge3d
branch
from
5ec234a to
3392c7c
Compare
MrBurmark
reviewed
Mar 15, 2023
Enable varying block sizes Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
MrBurmark
reviewed
Mar 21, 2023
MrBurmark
reviewed
Mar 21, 2023
pguthrey
force-pushed
the
feature/guthrey1/edge3d
branch
from
a502e59 to
09e59ed
Compare
pguthrey
force-pushed
the
feature/guthrey1/edge3d
branch
from
09e59ed to
71de550
Compare
|
@MrBurmark @pguthrey I merged develop into this, fixed build issues, and addressed several issues in reviewer comments. Is it good to merge? |
My plan is to finish this MR during the hackathon this week. I'll let you know once all the interested parties are happy. |
|
Ah I see the boilerplate spelling was fixed in 0987b08 |
MrBurmark
reviewed
Jul 26, 2023
CRobeck
reviewed
Jul 27, 2023
|
Something wrong with Lambda_HIP. Will investigate. |
MrBurmark
reviewed
Aug 1, 2023
MrBurmark
reviewed
Aug 1, 2023
MrBurmark
reviewed
Aug 1, 2023
MrBurmark
reviewed
Aug 1, 2023
Clarifying mem names Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
ibegin Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
pguthrey
commented
Aug 1, 2023
grid size
|
@MrBurmark I think this is good to go. |
MrBurmark
approved these changes
Aug 3, 2023
rhornung67
approved these changes
Aug 3, 2023
|
@MrBurmark @pguthrey checks are all green. Merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EDGE3D kernel computes the summed mass + stiffness matrix of low order edge bases, which is relevant to MHD discretizations.