New RAJA GPU Indexing #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in NESTED_INIT, POLYBENCH_2MM, and DIFFUSION3DPA
|
Updated this so we can get new performance results. It should be ready to go. |
|
@rhornung67 @artv3 Can I get a review? |
rhornung67
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Did you do all the kernels that use RAJA::kernel and RAJA::launch? I was going to work through that, but thank you for doing it @MrBurmark
artv3
approved these changes
Jul 26, 2023
|
I think I did all the kernels. |
This was referenced Jul 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new RAJA GPU indexing policies
This gives compile time knowledge of the block sizes in some kernels. This brings the RAJA variants closer in line with the base variants.
The base variants can still take a advantage of the knowledge that the ranges start at 0.