Commpath #117
Draft
Commpath #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, chosen_realized_cachepath was copied into set_intercept_readlink_cachepath() chosen_realized_cachepath and chosen_parsed_cachepath were copied into set_should_intercept_cachepath() This PR removes both setter functions and makes the original pointers global.
Removes chosen_cachepath and cachepath_bitindex from spindle_launch.h Updates initialization of matching variables in ldcs_process_data. determineValidCachePaths() moved from spindle_be.cc to ldcs_audit_server_process.c to get ldcs_process_data visibility. Added #include "parseloc.h" to ldcs_audit_server_process.c to get declaration of determineValidCachePaths(). Relocated "parseloc.h" to src/util so ldcs_audit_server_process.c could find it. Trued up signedness of types caused my making "parseloc.h" more visible, e.g., cachepath_bitidx is now uint64_t everywhere.
The three-message-reply response is now a single message with two strings. The symbolic version of the cachepath is no longer communicated as it was not being used.
New name is ldcs_audit_server_md_allreduce_AND(). If we get to the point where we're using other allreduce operations we can solve the problem of duplicating the op list in md-land and cobo-land. For now, we're only using one op in md-land, so the op can go into the function name.
Author
|
Found a failure case. Hold off on review for now. |
Unlikely it would ever make a difference, but this is much more correct.
src/client/beboot/spindle_bootstrap.c
Moved orig_location from static global to local
Renamed symbolic_location to symbolic_commpath
Renamed orig_location to orig_commpath
Renamed location to commpath
Renamed LDCS_LOCATION to LDCS_COMMPATH
src/client/client/client.c
Renamed LDCS_LOCATION to LDCS_COMMPATH
Renamed location to commpath
rountree
requested a deployment
to
Spindle CI
GitHub Actions
In progress
src/client/client_comlib/client_api.c
Added setenv("LDCS_CHOSEN_PARSED_CACHEPATH", local_cpc);
testsuite/test_driver.c
Replaced LDCS_LOCATION and LDCS_ORIG_LOCATION checks for cachepath with
LDCS_CHOSEN_PARSED_CACHEPATH
Replaced spindle_loc with cachepath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
locationenvironment variables, fields, and enums tocommpath.Builds with --with-rm=[flux|serial|slurm]. Can't build slurm-plugin, but that's not due to these changes.