Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using external fmt #834

Merged
merged 42 commits into from
Jan 30, 2024
Merged

Allow using external fmt #834

merged 42 commits into from
Jan 30, 2024

Conversation

adayton1
Copy link
Member

No description provided.

@adayton1 adayton1 changed the title Draft: Allow using external fmt Allow using external fmt Aug 21, 2023
@adayton1
Copy link
Member Author

@davidbeckingsale, what should I do about the spack package for Umpire needing fmt? There's a circular dependency between radiuss-spack-packages and Umpire.

@adayton1
Copy link
Member Author

I know I need to add something like:

depends_on("fmt@9.1:10", when="@develop")

@kab163 kab163 mentioned this pull request Jan 10, 2024
Closed
@adayton1
Copy link
Member Author

It passed!

kab163
kab163 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@kab163 kab163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I no longer see all the fmt notes/warnings when building this branch with the same cmake command as the one from my issue!

@davidbeckingsale davidbeckingsale merged commit 8579a31 into develop Jan 30, 2024
27 checks passed
@davidbeckingsale davidbeckingsale deleted the feature/dayton8/external_fmt branch January 30, 2024 21:22
kab163 added a commit that referenced this pull request Aug 1, 2024
@adayton1 @kab163
Allow using external fmt (#834)
6b069bd 
Co-authored-by: Kristi Belcher <belcher6@llnl.gov>
kab163 added a commit that referenced this pull request Aug 1, 2024
@adayton1 @kab163
Allow using external fmt (#834)
b3953ce 
Co-authored-by: Kristi Belcher <belcher6@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kab163 kab163 kab163 approved these changes

@white238 white238 Awaiting requested review from white238

@davidbeckingsale davidbeckingsale Awaiting requested review from davidbeckingsale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adayton1 @kab163 @davidbeckingsale